Skip to content

feat(components): micrometer observability baggages#23534

Merged
squakez merged 2 commits into
apache:mainfrom
squakez:feat/CAMEL-23415
May 27, 2026
Merged

feat(components): micrometer observability baggages#23534
squakez merged 2 commits into
apache:mainfrom
squakez:feat/CAMEL-23415

Conversation

@squakez
Copy link
Copy Markdown
Contributor

@squakez squakez commented May 26, 2026

Closes CAMEL-23415

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

davsclaus
davsclaus requested changes May 26, 2026
View reviewed changes
Comment thread components/camel-micrometer-observability/src/main/docs/micrometer-observability.adoc Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026 •
edited
Loading

🧪 CI tested the following changed modules:

  • components/camel-micrometer-observability
  • components/camel-opentelemetry2
  • components/camel-telemetry
All tested modules (12 modules)
  • Camel :: Common Telemetry
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Launcher :: Container
  • Camel :: Micrometer :: Observability 2
  • Camel :: Observability Services
  • Camel :: Opentelemetry 2
  • Camel :: Telemetry :: Dev
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin

⚙️ View full build and test results

gnodet
gnodet approved these changes May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition of baggage support to the Micrometer observation interceptor. The MICROMETER_BAGGAGE_ header prefix convention is clean, and the ScopedBaggages AutoCloseable helper ensures proper lifecycle management of baggage scopes. Removing the old BAGGAGE_CAMEL_FLAG in favor of the new approach simplifies the design.

Test coverage in BaggageSettingTest.java validates the flow.

LGTM.

Fully automatic review from Claude Code

@squakez squakez force-pushed the feat/CAMEL-23415 branch from 53395db to f6664a0 Compare May 27, 2026 07:02
@squakez squakez requested a review from davsclaus May 27, 2026 07:03
@squakez squakez force-pushed the feat/CAMEL-23415 branch from f6664a0 to 8a2250a Compare May 27, 2026 07:10
squakez added 2 commits May 27, 2026 09:20
@squakez
feat(components): micrometer observability baggages
8838d7a 
Closes CAMEL-23415
@squakez
feat(components): otel2 baggage from properties
165f129 
We uniform the logic after the change developed for the other telemetry components
@squakez squakez force-pushed the feat/CAMEL-23415 branch from 8a2250a to 165f129 Compare May 27, 2026 07:22
@squakez squakez merged commit f7a8ab4 into apache:main May 27, 2026
7 checks passed
@squakez squakez deleted the feat/CAMEL-23415 branch May 27, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnodet gnodet gnodet approved these changes

@davsclaus davsclaus davsclaus approved these changes

Assignees

No one assigned

Labels

components docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@squakez @gnodet @davsclaus